search

useblocks / sphinx-simplepdf

A simple PDF builder for Sphinx documentations
https://sphinx-simplepdf.readthedocs.io
MIT License
32 stars 14 forks source link

[#70] retry also in CalledProcessError #77

Closed kreuzberger closed 11 months ago

kreuzberger commented 1 year ago

In CI builds we sometime also see this error from weasyprint call: due to sometimes GLib:ERROR:.../glib-2.70.2/glib/gthread.c:814:g_thread_proxy: assertion failed: (data).

So the retry mechanism will be used on every exception occuring.

kreuzberger commented 1 year ago

Feedback from https://github.com/Kozea/WeasyPrint/issues/1870: msys2 libpango installation weasyprint relies on seems to be more stable than gtk3 package hinted from the installation guide

kreuzberger commented 1 year ago

Hi! Are there planings for merging into main or does is something missing?

kreuzberger commented 11 months ago

Tried to handle the both known exceptions and move retry handling into finally block. Currently under test in my CI, but the "good" case worked locally

danwos commented 11 months ago

Looks good to me. Shall I merge or are you still testing locally?

kreuzberger commented 11 months ago

I think you can merge, got no issues in CI with it.