search

useblocks / sphinx-simplepdf

A simple PDF builder for Sphinx documentations
https://sphinx-simplepdf.readthedocs.io
MIT License
32 stars 14 forks source link

Decouple theme and builder #94

Closed j123b567 closed 8 months ago

j123b567 commented 8 months ago

Decouple the theme from the builder completely

Alternate approach to #91

danwos commented 8 months ago

Thanks for the PR and for cleaning the code.

This is indeed more structured than the current solution and makes sense. However, one drawback is that scss-compilation is no embedded feature of Sphinx-SimplePDF anymore, and each theme has to deal with it on its own. But I guess that's fine and our source-code can be simply copied.

j123b567 commented 8 months ago

Closing in favor of #91