White screen on start when ELECTRON_IS_DEV=1

[PeterBenko]

The main window is white when starting Bruno while the ELECTRON_IS_DEV env variable is set to 1. Importing / trying to import collections has no influence on the main window.

Tested on:

• MacOS @ v1.5.1

  Preferences file is located at: /Users/<redacted>/Library/Application Support/bruno/preferences.json
  2023-12-20 15:52:08.687 Bruno[51581:6167298] WARNING: Secure coding is not enabled for restorable state! Enable secure coding by implementing NSApplicationDelegate.applicationSupportsSecureRestorableState: and returning YES.
  objc[51584]: Class WebSwapCGLLayer is implemented in both /System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore.framework/Versions/A/Frameworks/libANGLE-shared.dylib (0x23bbb9958) and /Applications/Bruno.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libGLESv2.dylib (0x10a33e978). One of the two will be used. Which one is undefined.
  (node:51581) electron: Failed to load URL:
  http://localhost:3000/
  with error: ERR_CONNECTION_REFUSED
  (Use `Bruno --trace-warnings ...` to show where the warning was created)
  Error: Failed to load URL: "
  http://localhost:3000"
  (Electron shows a blank screen because of this).
  Original message: Error: ERR_CONNECTION_REFUSED (-102) loading '
  [http://localhost:3000/'](http://localhost:3000/%27)
  at rejectAndCleanup (node:electron/js2c/browser_init:165:7506)
  at EventEmitter.failListener (node:electron/js2c/browser_init:165:7719)
  at EventEmitter.emit (node:events:527:28) {
  errno: -102,
  code: 'ERR_CONNECTION_REFUSED',
  url: '
  [http://localhost:3000/'](http://localhost:3000/%27)
  }
  Could not connect to Next.Js dev server, is it running? Start the dev server using "npm run dev:web" and restart electron  

• Windows 10 @ v1.4.0 & v1.5.0 & v1.5.1

  C:\Users\<redacted>\AppData\Local\Programs\bruno>set ELECTRON_IS_DEV=1 && Bruno.exe
  Preferences file is located at: C:\Users\<redacted>\AppData\Roaming\bruno\preferences.json
  (node:42884) electron: Failed to load URL: http://localhost:3000/ with error: ERR_EMPTY_RESPONSE
  (Use `Bruno --trace-warnings ...` to show where the warning was created)
  Error: Failed to load URL: "http://localhost:3000" (Electron shows a blank screen because of this).
  Original message: Error: ERR_EMPTY_RESPONSE (-324) loading 'http://localhost:3000/'
  at rejectAndCleanup (node:electron/js2c/browser_init:165:7506)
  at EventEmitter.failListener (node:electron/js2c/browser_init:165:7719)
  at EventEmitter.emit (node:events:527:28) {
  errno: -324,
  code: 'ERR_EMPTY_RESPONSE',
  url: 'http://localhost:3000/'
  }
  Could not connect to Next.Js dev server, is it running? Start the dev server using "npm run dev:web" and restart electron

[Its-treason]

This is the relevant code:

https://github.com/usebruno/bruno/blob/d268b4786abe07861ffd41e636a19013804f5015/packages/bruno-electron/src/index.js#L64-L86

When starting in dev mode, Bruno tries to open http://localhost:3000. When run in production mode, Bruno opens the JavaScript bundle included in the app.

If you try to run Bruno from source, make sure to run npm run dev:web before starting electron.

[PeterBenko]

Nice, straight to the point! However, I would postulate that isDev isn't the right tool for this use case and should actually be app.isPackaged. In the recent times when developing an Electron app - and having ELECTRON_IS_DEV permanently turned on - I leaned to expect many other apps opening the dev tools, which I understand - it basically flips them into debug mode. However, none of them straight up broke like Bruno did. The decision to use the dev-server served content isn't something that should be based on the debug flag. I'd say it should either be a run argument (like --useDevServer) or the above mentioned app.isPackaged check. Is Bruno ever expected to run not packaged in production?

I'm open to creating a PR for either of the fixes :)

[Its-treason]

Yeah, you're right, app.isPackaged would totally be the better option here. You can create a PR for this, if you want, we would appreciate it.

[PeterBenko]

1260 is open :)

[sebastian-xitaso]

@Its-treason Any update on this? We develop an Electron based app for which we set Electron_is_dev to 1. This means we can't use Bruno at the same time.

[Its-treason]

@Its-treason Any update on this? We develop an Electron based app for which we set Electron_is_dev to 1. This means we can't use Bruno at the same time.

Hey, I just added my Approved to the PR, but I cannot give you an ETA on when this will be merged. But it is a small change, so probably soon. CC @sanjai0py for visibility.