search

usebruno / bruno

Opensource IDE For Exploring and Testing Api's (lightweight alternative to postman/insomnia)
https://www.usebruno.com/
MIT License
22.27k stars 1.04k forks source link

Weird Unmovable scroll bar in the tablist section #2293

Open noornee opened 2 months ago

noornee commented 2 months ago

I have checked the following:

Describe the bug

There's a scrollbar-like bar appearing in my request tablist. (Check Screenshot) noticed this too in v1.16.1

.bru file to reproduce the bug

No response

Screenshots/Live demo link

bruno-ui-bug

end3rbyte commented 2 months ago

On which OS, mac, windows or linux ?

noornee commented 2 months ago

On which OS, mac, windows or linux ?

Linux.

end3rbyte commented 2 months ago

has anyone else the problem ? i don't but i am on windows

pietrygamat commented 2 months ago

On which OS, mac, windows or linux ?

Linux.

Looks like a custom DE theming problem. Are you using native or flatpak variant? I'd hope flatpak will not be affected regardless of what customisations are happening in the DE.

noornee commented 2 months ago

Looks like a custom DE theming problem

wow, don't know why i didn't think it could be my theme. I'll try to remove it entirely to see if it's the cause. (my theme is Adwaita)

Are you using native or flatpak variant?

Hyprland is my WM and I use the native variant of bruno or at least the one that's in the nixpkgs repository.

[edit]: nope, it's not my theme.

Its-treason commented 2 months ago

I saw those scrollbars after upgrading Electron to version 29 on my Lazer fork. They were caused by weird Bruno styling and the Chrome update.

Maybe the variant from NixOS also upgraded Electron. @noornee Could you open Bruno's Chrome DevTools and check the Chrome / Electron version?

Edit: The changes in https://github.com/Its-treason/bruno/commit/6412004ce2ff8d9b1461a2042b1faf6ef7069d98 (RequestTabs/StyledWrapper.js) should fix it.

noornee commented 2 months ago

I saw those scrollbars after upgrading Electron to version 29 on my Lazer fork. They were caused by weird Bruno styling and the Chrome update.

ahhh, I see.

Maybe the variant from NixOS also upgraded Electron. @noornee Could you open Bruno's Chrome DevTools and check the Chrome / Electron version?

Sure. I just did and yep, you're right. The electron version on my machine is v.29

electron_version

I will try to look into it tomorrow.

Alrightt, Thank you!

Its-treason commented 2 months ago

I looked into the Nix build file: https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/br/bruno/package.nix and the electron version in indeed overwritten:

https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/br/bruno/package.nix#L100-L112

noornee commented 2 months ago

I looked into the Nix build file: https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/br/bruno/package.nix and the electron version in indeed overwritten:

https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/br/bruno/package.nix#L100-L112

Woww, pheww!. Guess I'm going to open an issue in the nixpkgs repository to tell them to pin a specific version of electron for bruno.

Thanks for narrowing out the source of this bug @Its-treason 🕵️

By chance, do you know the version of electron that bruno uses or atleast the last working electron version that didn't affect bruno's request tablist ui?

I modified the bruno package file and tried to build it locally using electron v28 on my machine but i had some errors that i couldn't stay to resolve, was running late to school. I'll look into it properly when i get home though. my best bet is that it's because i replaced every occurrence of the word electron with electron_28 and it messed some things up

end3rbyte commented 2 months ago

I managed to reproduce it using the latest version of electron and I see how to fix it, I am making a PR

noornee commented 2 months ago

I managed to reproduce it using the latest version of electron and I see how to fix it, I am making a PR

that's awesome!

end3rbyte commented 2 months ago

Can I ask you @Its-treason to review my PR ?