[User experience] When closing a tab with request containing unsaved changes, I should be prompted whether those changes should be discarded or not

usebruno / bruno

Opensource IDE For Exploring and Testing Api's (lightweight alternative to postman/insomnia)

https://www.usebruno.com/

MIT License

21.93k stars 1.03k forks source link

[User experience] When closing a tab with request containing unsaved changes, I should be prompted whether those changes should be discarded or not #351

Closed lared closed 1 week ago

lared commented 9 months ago

When I close a tab with a request that has some unsaved changes (modified script or headers), those changes are not saved or discarded. They just sit there quietly, I can reopen the tab and they are still going to be there.

This means that:

I have absolutely no idea which requests I made changes to that might need saving (when the tab is closed, there is no indication that request has pending changes in it)
when I close Bruno, I might unknowingly lose some data from unsaved requests, as Bruno also doesn't prompt about pending changes when exiting the application AND doesn't save them anywhere

almirjakubaitis commented 9 months ago

Same problem in Ambient windows.

Does not save changes to modified requests with autosave.
When I clone a request, the data is saved in the new request.
I find that when I press CRTL + S save - everything is fine! But I think a file menu with the File > Save command should be more user-friendly.

lared commented 9 months ago

I see that core part (closing request doesn't prompt for changes) has been resolved in v0.21.1, but there are two areas left:

closing the application itself
closing variables window

eliasb-usafacts commented 9 months ago

In addition to a File -> Save menu, a File -> Save All (and/or a keyboard shortcut to save all unsaved requests) would be nice too

sanjai0py commented 1 week ago

I'm marking this issue as closed since it has already been implemented.

https://github.com/usebruno/bruno/pull/1317