usecannon / cannon

Manage EVM protocol deployments. Inspired by Docker, Terraform, and npm.
https://usecannon.com
GNU General Public License v3.0
104 stars 21 forks source link

fix(website): Correctly matching function inputs in ABI when signing a transaction #1223

Closed nicosampler closed 3 months ago

nicosampler commented 3 months ago

This fix addresses the issue in #411, where the code was incorrectly retrieving the first matching function inputs from the ABI. Now, it selects the function inputs by matching the function name and the exact count of arguments specified in the decodedFunctionData.

Closes https://linear.app/usecannon/issue/CAN-411/website-displays-wrong-function-when-same-name-on-sign-transaction

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 5993b93bbf73b4981edec654bdd97e68c8a4faed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud[bot] commented 3 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5993b93bbf73b4981edec654bdd97e68c8a4faed. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target - [`lerna run build --ignore cannon-website --ignore @usecannon/indexer --ignore repo --ignore @usecannon/api`](https://cloud.nx.app/runs/z8rcleYrZx?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.