usecannon / cannon

Manage EVM protocol deployments. Inspired by Docker, Terraform, and npm.
https://usecannon.com
GNU General Public License v3.0
104 stars 21 forks source link

fix(website): CAN-431 Navigating among contracts in interact losses method references. #1241

Closed nicosampler closed 3 months ago

nicosampler commented 3 months ago

This PR fixes two bugs:

  1. When moving among contracts listed in the header in the interact section, methods lose reference and fail when trying to call them with a message similar to this one: "Args parameters don't match". It was fixed by setting a unique key on the map that renders the box with the functionality to interact with the method. Before, it was using the map.index as the key, now the key is created using the contract address and the method selector.

  2. I've also fixed the issue where the contract selected loses the "selected border" when moving between methods.

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: f8f6600778d3864ec2203262ea317bd2a7876bb8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud[bot] commented 3 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f8f6600778d3864ec2203262ea317bd2a7876bb8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target - [`lerna run build --ignore cannon-website --ignore @usecannon/indexer --ignore repo --ignore @usecannon/api`](https://cloud.nx.app/runs/KOcG4qGOTX?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.