usecannon / cannon

Manage EVM protocol deployments. Inspired by Docker, Terraform, and npm.
https://usecannon.com
GNU General Public License v3.0
104 stars 21 forks source link

fix(builder): fix invoke getInputs take array or string #1243

Closed FuzzB0t closed 3 months ago

FuzzB0t commented 3 months ago

Turns out the error only happened because we allowed targets to be defined as strings as well which was causing the getInputs function to incorrectly return values, causing the computation of dependencies to fail.

fixes https://linear.app/usecannon/issue/CAN-405/invoke-implicit-depends-bug

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 2136a3e6a20780a373f5c57ab9ae018e22892db3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud[bot] commented 3 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2136a3e6a20780a373f5c57ab9ae018e22892db3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target - [`lerna run build --ignore cannon-website --ignore @usecannon/indexer --ignore repo --ignore @usecannon/api`](https://cloud.nx.app/runs/E81FVs1edY?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.