Closed FuzzB0t closed 3 months ago
Latest commit: 6f85e9da9e8549111f2406a6721495260eeb4cb5
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
CI is running/has finished running commands for commit 6f85e9da9e8549111f2406a6721495260eeb4cb5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud.
There's a lint issue, but aside from that 🚀
need tests specifically addressing the resolved issues. for example not clear if this actually fixes the "disallow dry run flag on local build" fix. also in general, quite a lot of changes here and need to verify them
yeah technically this is enabling dry runs on local builds so I will fix that and add tests.
fixes https://linear.app/usecannon/issue/CAN-422/cli-disallow-specifying-dry-run-for-local-build fixes https://linear.app/usecannon/issue/CAN-426/hide-cli-copy-during-dry-run fixes https://linear.app/usecannon/issue/CAN-196/warn-when-building-if-its-using-default-signer-when-using-a-remote fixes https://linear.app/usecannon/issue/CAN-418/cannon-build-cannonfiletoml-dry-run-does-not-work