usecannon / cannon

Manage EVM protocol deployments. Inspired by Docker, Terraform, and npm.
https://usecannon.com
GNU General Public License v3.0
104 stars 21 forks source link

fix(cli): Add better outputs for dry run and allow dry run on local network #1250

Closed FuzzB0t closed 3 months ago

FuzzB0t commented 3 months ago

image

image

fixes https://linear.app/usecannon/issue/CAN-422/cli-disallow-specifying-dry-run-for-local-build fixes https://linear.app/usecannon/issue/CAN-426/hide-cli-copy-during-dry-run fixes https://linear.app/usecannon/issue/CAN-196/warn-when-building-if-its-using-default-signer-when-using-a-remote fixes https://linear.app/usecannon/issue/CAN-418/cannon-build-cannonfiletoml-dry-run-does-not-work

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 6f85e9da9e8549111f2406a6721495260eeb4cb5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud[bot] commented 3 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6f85e9da9e8549111f2406a6721495260eeb4cb5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target - [`lerna run build --ignore cannon-website --ignore @usecannon/indexer --ignore repo --ignore @usecannon/api`](https://cloud.nx.app/runs/TfBQPikmGv?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

mjlescano commented 3 months ago

There's a lint issue, but aside from that 🚀

FuzzB0t commented 3 months ago

need tests specifically addressing the resolved issues. for example not clear if this actually fixes the "disallow dry run flag on local build" fix. also in general, quite a lot of changes here and need to verify them

yeah technically this is enabling dry runs on local builds so I will fix that and add tests.