usecannon / cannon

Manage EVM protocol deployments. Inspired by Docker, Terraform, and npm.
https://usecannon.com
GNU General Public License v3.0
104 stars 21 forks source link

fix(cli): remove `--fork-url` and similar from build command #1290

Closed dbeal-eth closed 2 months ago

dbeal-eth commented 3 months ago

users should always specify --rpc-url instead and let cannon do its thing

fixes https://linear.app/usecannon/issue/CAN-254/fork-url-is-not-being-taken-into-account-if-private-key-and-chain-id

note: should this also be removed from the cannon run command? I am trying to think of a case where --fork-url would be different from --rpc-url?

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 1301f2823a731698699e95ac5e43d6c6bab1b9d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud[bot] commented 3 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1301f2823a731698699e95ac5e43d6c6bab1b9d2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target - [`lerna run build --ignore cannon-website --ignore @usecannon/indexer --ignore repo --ignore @usecannon/api`](https://cloud.nx.app/runs/izIqLWYZYP?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.