usecannon / cannon

Manage EVM protocol deployments. Inspired by Docker, Terraform, and npm.
https://usecannon.com
GNU General Public License v3.0
104 stars 21 forks source link

fix(website): Use Ipfs reference for partial deploy on web #1305

Closed FuzzB0t closed 2 months ago

FuzzB0t commented 2 months ago

fixes https://linear.app/usecannon/issue/CAN-444/add-deployments-from-partial-deploy-file

This ticket redesigns the deploy page and removes the need to specify cannonfile url in partial deployments on the web app.

Below is an example of running a partial deployment (I ran the same thing on the current instance of the website and confirmed the error response was the same on there)

Without cannonfile ref:

https://www.loom.com/share/054e6dda24aa47aebd4f0c729ed83f61

With cannonfile ref:

https://www.loom.com/share/aa0414806f364c679e8b9978525cb5aa

Also added the ability to specify chain id on pin command since it was not pinning partial deployment hashes on other networks

changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: b6cdcfe0538cf4416cf880591f2128d0ed1dbcc6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud[bot] commented 2 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b6cdcfe0538cf4416cf880591f2128d0ed1dbcc6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target - [`lerna run build --ignore cannon-website --ignore @usecannon/indexer --ignore repo --ignore @usecannon/api`](https://cloud.nx.app/runs/e2l6R3bRaK?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

FuzzB0t commented 2 months ago

Currently the UI is allowing you to just paster a cannonfile without a partial deployment file, which it shouldn't: Screenshot 2024-08-26 at 18 54 22

I disabled the cannonfile input when a partial deployment hash hasnt been provided

mjlescano commented 2 months ago

When landing for the first time on the gitops deployment page, directly from the link or navigating, there's no radio button selected by default, when the first one should be selected:

Screenshot 2024-08-27 at 11 46 51