usecannon / cannon

Manage EVM protocol deployments. Inspired by Docker, Terraform, and npm.
https://usecannon.com
GNU General Public License v3.0
103 stars 20 forks source link

fix(cli): Refactor pin command #1320

Closed FuzzB0t closed 2 weeks ago

FuzzB0t commented 1 month ago

This PR refactors the pin command to have its own function in the CLI, however to avoid duplicating code I think it might be better if the pin command stays within a function in the builder (named pin respectively) so that both the cli's pin command and the builder's preparePublishPackage function can both use the code.

Might be nice to add the ability to pin from the webapp and add a button for explicit navigation to /ipfs which will let you download and/or pin hashes from/to IPFS

fixes https://linear.app/usecannon/issue/CAN-467/cannon-pin-should-not-require-chain-id-when-pinning-using-an-ipfs-hash

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: bae903299637062d63f116053004ee0b0e658484

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud[bot] commented 1 month ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 12222e5bdde06256f8b8ca7c83658ba43c1d7043. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target - [`lerna run build --ignore cannon-website --ignore @usecannon/indexer --ignore repo --ignore @usecannon/api`](https://cloud.nx.app/runs/3wIxG6NRoa?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

dbeal-eth commented 3 weeks ago

@FuzzB0t is this done? are we goingt o fix the test failures?

FuzzB0t commented 2 weeks ago

@FuzzB0t is this done? are we goingt o fix the test failures?

Yes its done, the tests are failing due to another intermittent error that has been happening on CI for a while. Merging it now.