Closed FuzzB0t closed 2 weeks ago
Latest commit: bae903299637062d63f116053004ee0b0e658484
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
CI is running/has finished running commands for commit 12222e5bdde06256f8b8ca7c83658ba43c1d7043. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud.
@FuzzB0t is this done? are we goingt o fix the test failures?
@FuzzB0t is this done? are we goingt o fix the test failures?
Yes its done, the tests are failing due to another intermittent error that has been happening on CI for a while. Merging it now.
This PR refactors the pin command to have its own function in the CLI, however to avoid duplicating code I think it might be better if the pin command stays within a function in the builder (named
pin
respectively) so that both the cli'spin
command and the builder'spreparePublishPackage
function can both use the code.Might be nice to add the ability to pin from the webapp and add a button for explicit navigation to
/ipfs
which will let you download and/or pin hashes from/to IPFSfixes https://linear.app/usecannon/issue/CAN-467/cannon-pin-should-not-require-chain-id-when-pinning-using-an-ipfs-hash