search

usecannon / cannon

Manage EVM protocol deployments. Inspired by Docker, Terraform, and npm.
https://usecannon.com
GNU General Public License v3.0
104 stars 21 forks source link

fix(builder): Replace viem getUrl calls to registry with axios #1351

Closed FuzzB0t closed 1 month ago

FuzzB0t commented 2 months ago

Replaces getUrl and getMetaUrl to use axios to make rpc calls to the registry

changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: ac73ed911c848489481eb74f6d7262974b06b14d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

saeta-eth commented 2 months ago

What is the motivation for this PR? I am out of the loop and it seems confusing

FuzzB0t commented 2 months ago

What is the motivation for this PR? I am out of the loop and it seems confusing

@saeta-eth We we're seeing a lot of issues with the registry get calls and RPC's so db mentioned we could optimize the calls by using axios to make rpc requests instead of viem. There may be other reasons for this PR but that was the main one AFAIK.