search

usecannon / cannon

Manage EVM protocol deployments. Inspired by Docker, Terraform, and npm.
https://usecannon.com
GNU General Public License v3.0
104 stars 21 forks source link

fix(website): CAN-493 switch chain instead of sign #1362

Closed nicosampler closed 2 months ago

nicosampler commented 2 months ago

Fixes the case where the button should show the text "Switch chain" instead of "Sign"

changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: b2392fb9b3bf45f24d75268e928496e540de3ade

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nicosampler commented 2 months ago

I just want to confirm but I thought previously we set it up so that if you click the sign button, it does both the switch Network and sign at the same time, so I'd rather use that functionality if possible. Do you have a video?

yes, I found that behavior quite invasive, as you are prompted to sign something without requesting it. But I can bring it back, of course.

nicosampler commented 2 months ago

@dbeal-eth, sorry I misread your comment.

The thing is that the users are complaining about the sign&switch unified actions. So this ticket is about to split it up and first show the switch button and then the sign one. That's why I've removed the nested action.