usecannon / cannon

Manage EVM protocol deployments. Inspired by Docker, Terraform, and npm.
https://usecannon.com
GNU General Public License v3.0
104 stars 21 forks source link

fix(cli): settings lost their memoized values #1367

Closed saeta-eth closed 2 months ago

saeta-eth commented 2 months ago

We need to memoize/cache the settings once they're used. In many parts of the code, we call resolveCliSettings without arguments, expecting it to return the memoized value. However, this isn't happening, and as a result, we're using incorrect settings. I've detected this issue in the decode command, but I'm fairly certain it's occurring throughout the project.

For instance, cannon decode synthetix-omnibus:3.3.4@main 0x243fc3d98160ae6ec9f764dd688cbc4c99d29f30d5e28ebefdc4968a45371ce3 --rpc-url https://mainnet.gateway.tenderly.co is not using the RPC url and instead its using the default Viem values.

Closes https://linear.app/usecannon/issue/CAN-515/settings-lost-their-memoized-values

changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: 69123a5e2059602e51db993e76ab09cc88d64e9d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR