usecannon / cannon

Manage EVM protocol deployments. Inspired by Docker, Terraform, and npm.
https://usecannon.com
GNU General Public License v3.0
103 stars 20 forks source link

fix(website): gitops deployment was missing chainId #1378

Closed mjlescano closed 2 weeks ago

mjlescano commented 2 weeks ago

This PR fixes the gitops deployment page, by doing the actual fix first, and also fixing the types on the builder so this kind of error is less likely.

  1. The website hook was initialising the simulated build without chainId, that's fixed here: https://github.com/usecannon/cannon/pull/1378/files#diff-1c16184636ccf287d09107e881baa71fba0cc29067ff908c276919cf5922d6b4R266
  2. Now, when fetching deployment packages we make sure it includes chainId to be consistent with old deployments, kinda like a migration: https://github.com/usecannon/cannon/pull/1378/commits/9c6c542b628e755ae4ac5e7f1c89df834da64a64
changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: bf1b6e8d16cfdba16e73256865aa84b51b2079db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR