search

usecannon / cannon

Manage EVM protocol deployments. Inspired by Docker, Terraform, and npm.
https://usecannon.com
GNU General Public License v3.0
103 stars 20 forks source link

fix(cli): publish command using ipfs hash #1398

Closed saeta-eth closed 1 week ago

saeta-eth commented 1 week ago

The primary issue was that the publish command failed to recognize whether a package was already registered, prompting for registration unnecessarily.

Additionally, this PR simplifies the logic by standardizing the usage of fullPackageRef. Instead of managing two different formats, the IPFS hash is used to derive the fullPackageRef, which is then handled consistently throughout the publish command

Closes https://linear.app/usecannon/issue/CAN-495/cannon-publish-with-ipfs-hash-fails-when-there-is-no-local-entry-only

changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: 91431289e03ab6a8cd6eea5bf65dbb134f1607b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR