search

usecannon / cannon

Manage EVM protocol deployments. Inspired by Docker, Terraform, and npm.
https://usecannon.com
GNU General Public License v3.0
104 stars 21 forks source link

fix(publish): chain id setup #1408

Closed mjlescano closed 1 month ago

mjlescano commented 1 month ago

Closes https://linear.app/usecannon/issue/CAN-559/chainid-is-being-set-to-13370

This PR fixes two bugs:

  1. When running cannon publish including clone steps, it was wrongly publishing the subpackages with the 13370 chain instead of the target chain, that is addressed here: https://github.com/usecannon/cannon/pull/1408/files#diff-756d4c0d0bd036727ea6922554c95272acc0b2e94bd8311308f1a69574d94f82R98
  2. When running cannon build, the imports of clone steps were having always the chainId 13370, this is fixed here: https://github.com/usecannon/cannon/pull/1408/files#diff-950232bdec873b2ee3a9f82132b20b978b8ae9fcf3be3a475e613efee95046f6R256
changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 9e8c86a56f1ea3870662ad8e1ea8d9a3c7bf7a7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dbeal-eth commented 1 month ago

fix confirmed, going to merge this as is.