search

usefathom / fathom

Fathom Lite. Simple, privacy-focused website analytics. Built with Golang & Preact.
https://usefathom.com/
MIT License
7.55k stars 368 forks source link

Prevent tracking pageview from localhost #291

Closed EnKrypt closed 4 years ago

EnKrypt commented 5 years ago

This fixes #287

EnKrypt commented 5 years ago

@JackEllis Pinging cause it's been a while. Let me know if you've had the time to take a look at this.

EnKrypt commented 4 years ago

@JackEllis any kind of update would be cool. It's been a month and a half.

Just FYI, this patch is only 3 lines of code, so shouldn't take more than a minute to review if you decide to.

fjeddy commented 4 years ago

This should be optional, not forced... This code would require you to push to a live / dev site before you can test if Fathom is working correctly.

JackEllis commented 4 years ago

@fjeddy I agree 100%. Our advice on how to ignore tracking from localhost is here: https://usefathom.com/support/localhost

EnKrypt commented 4 years ago

This is bad advice. Yes, it should be optional of course, but it should be the other way around.

I'd wager that most people don't want to track localhost and in the case where you have to test fathom before deploying, that phase lasts for a short while before it is eventually deployed to production for its remaining lifespan where this feature is not required.

Ignoring localhost thus should be the default, with tracking localhost being an option you can go out of your way to enable.

At least, this is my opinion. It seems to be a feature that quite a few people want.