search

useful-forks / useful-forks.github.io

Improving GitHub's Forks list discoverability through automatic filtering. The project offers an online tool and a Chrome extension.
https://useful-forks.github.io/
MIT License
1.18k stars 61 forks source link

adapt to github's night mode #25

Closed odnar-dev closed 3 years ago

odnar-dev commented 3 years ago

closes https://github.com/useful-forks/useful-forks.github.io/issues/4

TheTechRobo commented 3 years ago

Isn't #21 already fixing this?

payne911 commented 3 years ago

Isn't #21 already fixing this?

Yes and no. #21 proposes the creation of a new file, rather than editing the one associated with the Chrome plugin. I'm not 100% certain I'll be merging #21 as is, and will need to evaluate whether I can simply add its content directly into the Chrome script.

In the meantime, since it contained solutions to 2 current problems with the Chrome script, I suggested that he create separate PRs for those fixes. :)

@odnar-dev am I allowed to modify your PR ? (I believe you would have a checkbox for that somewhere on the right side.)

payne911 commented 3 years ago

Thanks for your contribution, @odnar-dev !