search

useful-forks / useful-forks.github.io

Improving GitHub's Forks list discoverability through automatic filtering. The project offers an online tool and a Chrome extension.
https://useful-forks.github.io/
MIT License
1.18k stars 61 forks source link

Closed #42

Closed fregante closed 1 year ago

payne911 commented 2 years ago

If the pop up appears, it's because a token needs to be provided in order to show more results.

Unfortunately, unauthenticated calls get rate limited at a prohibitively low amount of requests. I personally would assume that it is so low that in the great majority of cases where someone might want to use Useful-Forks to analyze a list of forks, it would barely show any relevant results. That is why I think it makes sense to have this process be a bit "intrusive": it's a one-time setup which gets saved in the browser and reused on subsequent accesses.

However, maybe there is a middle-ground: the pop-up would remain the default behavior, but a URL parameter could potentially control how that alert gets raised (something like &popup=false).

payne911 commented 1 year ago

Would you expect the link to open that dialog? What is the gain in requiring an extra click from users?

KaKi87 commented 1 year ago

Adding an extra click is bad, I agree.

Also, "agressively" seems overstated to me.

But as an alternative to OP's request, putting the token input inside the banner would work, right ?

payne911 commented 1 year ago

I'm not sure why this user is reacting as they are with regards to this issue. I do believe it's a valid concern, but I just don't have much time to dedicate to fixing it. I'd love for someone to work on this properly, but I removed the help wanted badge from the issue because I had it plastered on so many issues that it felt "spammy" and didn't seem like it helped orient potential helpers toward issues I find more important.

My personal view on this is summarized here:

Please add a URL parameter which can be used to disable the popup. I personally will be keeping the popup as the default behavior for now.

Also, if the popup isn't displayed, this message banner should be better at directing the user: instead of the part that mentions the button at the top-right, it should contain a text field with the token value in it, and some buttons to create and save. Thus, it would essentially provide the same user experience as the popup. And depending on how that looks and feels, I might consider removing the popup entirely.

fregante commented 1 year ago

Your request is different from mine, you can create a dedicated issue

payne911 commented 1 year ago

This feels a bit passive-aggressive...

image image