search

useful-forks / useful-forks.github.io

Improving GitHub's Forks list discoverability through automatic filtering. The project offers an online tool and a Chrome extension.
https://useful-forks.github.io/
MIT License
1.18k stars 61 forks source link

Update manifest.json from V2 to V3 format #47

Closed gers1978 closed 1 year ago

gers1978 commented 2 years ago

Converted the manifest to V3 format from V2 format due to V2 manifests being deprecated and phased out in favour of V3 manifests in 2023.

payne911 commented 1 year ago

@gers1978 have you tested this?

I'm not entirely sure, but iirc V3 is part of an upgrade that will deprecate usage of ad blockers, which quite a few users might not be interested in following. I'm guessing some users might be interested in keeping access to a V2 available if they feel like using another Chromium-based browser. Any thoughts on that?

gers1978 commented 1 year ago

@gers1978 have you tested this?

I'm not entirely sure, but iirc V3 is part of an upgrade that will deprecate usage of ad blockers, which quite a few users might not be interested in following. I'm guessing some users might be interested in keeping access to a V2 available if they feel like using another Chromium-based browser. Any thoughts on that?

Ok fair enough, but yes, it works fine.

payne911 commented 1 year ago

I had a few more changes to put in, and it was easier to do locally.

I upgraded to v3 because the current Chrome Browser doesn't seem to yet to disallow the AdBlocker anyways... so v2 is just a sub-part option at this point.

Thanks for raising this issue and showing how easy it would be to upgrade. 👍

See https://github.com/useful-forks/useful-forks.github.io/commit/61c8e9a8d0271ca3636210e70039cb8b6f7863d8