Ask for token less aggressively

[fregante]

• Close #42

I noticed that a banner is already shown, so it doesn't also need to show a popup.

I should also say that the website is needlessly verbose, both in the banner and in the popup. The core information is just "A token is required to parse the entire fork tree due to GitHub API limits"

[fregante]

Testable at https://useful-forks.vercel.app/?repo=reactjs/react-autocomplete

I will update the URL in Refined GitHub to the above one until this PR is merged

[payne911]

Sorry for the slow response. I was away on a business trip.

I should also say that the website is needlessly verbose, both in the banner and in the popup.

Yet I've received feedback about how people appreciate the current flow and how it tells you why a token is required.

Have you been getting people reporting issues on refined-github due to this specific dialog feeling "too spammy" ?

until this PR is merged

Please add a URL parameter which can be used to disable the popup. I personally will be keeping the popup as the default behavior for now.

Also, if the popup isn't displayed, this message banner should be better at directing the user: instead of the part that mentions the button at the top-right, it should contain a text field with the token value in it, and some buttons to create and save. Thus, it would essentially provide the same user experience as the popup. And depending on how that looks and feels, I might consider removing the popup entirely.

[KaKi87]

Please add a URL parameter which can be used to disable the popup. I personally will be keeping the popup as the default behavior for now.

Then the contribution would become useless as no visitor will ever know about it.

[payne911]

Then the contribution would become useless as no visitor will ever know about it.

I agree, and I personally wouldn't integrate my tool with that URL parameter in it, but at least it would be available for people like @fregante which wants this popup to be gone at all cost.

The obviously better approach is what I talked about in the next paragraph to the one you quoted:

if the popup isn't displayed, this message banner should be better at directing the user: instead of the part that mentions the button at the top-right, it should contain a text field with the token value in it, and some buttons to create and save. Thus, it would essentially provide the same user experience as the popup.

[KaKi87]

at least it would be available for people like @fregante which wants this popup to be gone at all cost

Except the feature is only useful when using the app for the first times, while once a token is entered, it's never needed again, so it won't matter.

[KaKi87]

The obviously better approach is what I talked about in the next paragraph to the one you quoted

So if what you talk about is implemented then you will agree to make that behavior default ?

I would be okay with that, but that's not how I understood your message.

[payne911]

So if what you talk about is implemented then you will agree to make that behavior default ? I would be okay with that, but that's not how I understood your message.

I think my stance is pretty clear. Quoting, again, that same paragraph:

And depending on how that looks and feels, I might consider removing the popup entirely.

Essentially: if this improves UI/UX, I don't see why I would keep the old way (i.e. popup). But if the execution is bad (e.g. the current implementation of #62), I don't see why I would want to replace a functional thing for some poor implementation.

[fregante]

wants this popup to be gone at all cost

No the popup can stay, the feature isn't part of Refined GitHub anymore so any changes or lack of changes here don't affect me. This is my last message on this repo