Feature/refresh token flow

usefulteam / jwt-auth

WordPress JSON Web Token Authentication

https://wordpress.org/plugins/jwt-auth/

124 stars 50 forks source link

Feature/refresh token flow #116

Open marchrius opened 8 months ago

marchrius commented 8 months ago

Supports to REST API flow (in body or parameter) instead of cookie. The flow can be changed by hook 'jwt_auth_flow'.

[x] Implement different flow
[x] Edit tests to test the different flow
[x] Update README.md

rtorrente commented 7 months ago

Hello @marchrius,

Very interested by your PR, i'm facing the same issue

Is there anything missing from this MR to send it in for review? Do you need help?

marchrius commented 7 months ago

Hi @rtorrente,

the missing part is the README.md update with docs on new error codes and how to use the flow hook.

dominic-ks commented 2 months ago

@marchrius are you able to have a look at @sun 's requested changes? It would be good to get this in as a few people are asking.

marchrius commented 2 months ago

Hi @sun and @dominic-ks, I'll be happy to do that, can you give me some pointers on what might be the best way to split the two things?

I'm using PHPStorm as IDE and I have the option PHP -> Framework -> WordPress -> Enable WordPress integration to help me format the code automatically.

If you have some default rules I can use them for future commits and style changes.

sun commented 2 months ago

For the moment it would be best to disable all automated formattings and then revert all changes in this PR that are not functional changes.

In an issue separate from this here we can look into correcting the formatting – although I think we’ll rather look at automations like prettier and phpcs to do so, so that it doesn’t depend on anyone’s editor settings.

marchrius commented 1 month ago

Hi @sun, I've removed all non-necessary integrations and style modifications.