Fixed Auth and Devices class methods cannot be accessed from integration plugins.

sun commented 3 years ago

Problem

When trying to implement custom integration code outside of the jwt-auth plugin, the methods of the Auth and Devices class instances cannot be accessed.

Cause

The instances of the classes are not made available by the jwt-auth plugin.

Proposed solution

Convert the class JWTAuth\Setup into a singleton, so that JWTAuth\Setup::getInstance() allows access to the instantiated classes.

Notes

Instead of making the $auth and $devices properties public, we can also consider to add dedicated Setup::getAuth() and Setup::getDevices() methods.

sun commented 2 years ago

@contactjavas Did you have a chance to look into this? It's fairly simple change without visible effect. It is oaky if I proceed and merge it myself if you're fine with it?

contactjavas commented 2 years ago

Hi @sun , I'm sorry, unfortunately I'm still not able to to find the time to test PRs. Please merge it if you're confident with the changes.

Thanks for keeping the plugin active! I'd be happy to push update to the WP SVN at some point.

usefulteam / jwt-auth

Fixed Auth and Devices class methods cannot be accessed from integration plugins. #34