Need for a unique and permanent identifier of channels

[wm75]

atm, we're keeping track of where things got posted and work out where to post new items through the name attributes in the plugins.yml, so this implies that these names will never change. At the same time we're using these as "labels" to hint at their meaning, and that means we would perhaps want to change them (for example there might be more than just one "slack" channel in the future.

So it would be good to separate the "id" and "label" concepts and never change ids afterwards.

[bgruening]

nice catch, also also document that the ID needs to stay stable in our examples and documentations.

[arash77]

So, do we have to address each social media channel with an ID instead of a label?

[wm75]

Not completely sure about this. I would say the name/label will be more user-friendly and the processed_files.json could still record the id. The disadvantage is that the content of /posts might contain headers with outdated names/labels, but that would make it just a bit harder to trace back where a given post was sent to, not impossible.

[arash77]

I was thinking about this and I got a new idea that I am unsure if it fits our situation. what if we have this config for the plugins.yml for example:

- name: slack
  class: slack.slack_client
  accounts:
    '1':
      enabled: true
      config:
        access_token: "$SLACK_ACCESS_TOKEN"
        channel_id: "$SLACK_CHANNEL_ID"
        max_content_length: 40000
    '2':
      enabled: true
      config:
        access_token: "$SLACK_ACCESS_TOKEN2"
        channel_id: "$SLACK_CHANNEL_ID2"
        max_content_length: 40000

We can therefore call them in the post configs media, for example, slack#1 and slack#2. Also the same format in processed_files.json: {"slack#1": true} This way we combine the label and id, and make sure that the name won't get changed. What do you think about this? @bgruening @wm75

[wm75]

Looks neat, but I'm still worried about poorly chosen names that you'd later like to change. Like say, we now set up an "account" that posts to a certain matrix room as "usegalaxy-eu" and name it only after the room. But later .org decides that they would like to post to that same room under a different identity, so you would like to include "eu" in the name of the existing account. Or you decide to rename the room at some point and would like to rename the "account" accordingly. If you decide to change the name you'd still invalidate the processed_files.json.

[arash77]

@wm75 So, something like this would be better?:

- name: slack
  class: slack.slack_client
  accounts:
    '1':
      name: 'usegalaxy-eu-eu'
      enabled: true
      config:
        access_token: "$SLACK_ACCESS_TOKEN"
        channel_id: "$SLACK_CHANNEL_ID"
        max_content_length: 40000
    '2':
      name: 'usegalaxy-eu-org'
      enabled: true
      config:
        access_token: "$SLACK_ACCESS_TOKEN2"
        channel_id: "$SLACK_CHANNEL_ID2"
        max_content_length: 40000

The label would be slack.usegalaxy-eu-eu and slack.usegalaxy-eu-org. The ID that will be used in processed_files.json would be slack#1 and slack#2.