usegalaxy-eu / galaxy

Data intensive science for everyone.
https://galaxyproject.org/
Other
2 stars 11 forks source link

Fix for fits_image_viewer visualization plugin #218

Closed francoismg closed 7 months ago

francoismg commented 7 months ago

Fixing a bug occurring in the usegalaxy.eu instance for the fits_image_viewer visualization plugin

As discussed in https://github.com/usegalaxy-eu/galaxy/issues/194

Original PR in main galaxy repo https://github.com/galaxyproject/galaxy/pull/17002

The fits_image_viewer (used for visualization of FITS file) has been unusable on usegalaxy.eu and on some local instances.

Two differents bugs are causing this issue (more details can be found in this issue https://github.com/usegalaxy-eu/galaxy/issues/194) :

The first one is only related to the usegalaxy.eu server that doesn't serve the correct mime type for web assembly file
The second one is caused by the aladin lite js files not being copied to the correct location.

This fix makes the plugin relies on the university of strasbourg CDN (which should be a workaround for the server mime type issue) with a fallback to local aladin lite js files if the cdn were not to be available.

The second fix is to force the creation of the aladin lite folder directly on the build script in order to resolve the issue that on some instances the folder was not created correctly which caused some missing js files error

@bgruening since the plugin is not usable right now on galaxy.eu we were wondering what kind of timeframe we should expect for the fix to be pushed to galaxy.eu prod, thanks How to test the changes?

Instructions for manual testing are as follows:
    Upload a fits file to galaxy (one should be present on the test-data folder)
    Use the visualization plugin to open the fits file (after a few second a map of space should be displayed with the content of the file in the middle)

License

I agree to license these and all my past contributions to the core galaxy codebase under the [MIT license](https://opensource.org/licenses/MIT).