search

usegalaxy-eu / infrastructure-playbook

Ansible playbook for managing UseGalaxy.eu infrastructure.
MIT License
16 stars 91 forks source link

Use role `grycap.htcondor` from usegalaxy-eu organization #1234

Closed kysrpex closed 1 month ago

kysrpex commented 2 months ago

As part of the migration to HTCondor 23, the role managing HTCondor was switched from usegalaxy_eu.htcondor to grycap.htcondor. I forked it and added linting and a couple of tests on top, and that fork is what useGalaxy.eu is running today.

However, the entry for grycap.htcondor in requirements.yaml still points to that fork https://github.com/kysrpex/grycap-ansible-role-htcondor on my personal account. This is wrong for many reasons.

This commit changes the source URL of the role to a fork on the usegalaxy-eu organization.

Useful information from the GitHub docs: What happens to forks when a repository is deleted or changes visibility?

mira-miracoli commented 2 months ago

Thanks, I guess we should activate the workflows in the repo? Also a question; the upstream repo is now your repo, but would it make sense to set the original https://github.com/grycap/ansible-role-htcondor repo as upstream?

kysrpex commented 2 months ago

Thanks, I guess we should activate the workflows in the repo? Also a question; the upstream repo is now your repo, but would it make sense to set the original https://github.com/grycap/ansible-role-htcondor repo as upstream?

Thanks, I just activated the workflows. It would make a lot of sense. I am betting that when I delete my repository, the fork on usegalaxy-eu will switch to the upstream automatically (see GitHub docs)

When you delete a public repository, one of the existing public forks is chosen to be the new upstream repository. All other repositories are forked off of this new upstream and subsequent pull requests go to this new upstream repository.

It is a "bet" because they do not specify which public fork becomes the upstream. It may as well be a random one. Do you know if the upstream of a fork on GitHub can be changed manually? If not we can first gamble and if we're unlucky then investigate?