search

usegalaxy-eu / workflow-testing

Automated testing of workflows against Galaxy
10 stars 21 forks source link

New metaproteomics workflow for F1000 Query Tabular paper #35

Closed pravs3683 closed 5 years ago

bgruening commented 5 years ago

@pravs3683 awesome! Works for me locally! Do you want to include more tests, or do you think one is enough?

pravs3683 commented 5 years ago

Thanks @bgruening . I have added few more test. Two more separate workflows will be coming up soon after this.

bgruening commented 5 years ago

Awesome! Keep them coming :)

bgruening commented 5 years ago

With the last workflow which you added I also get a toolshed.g2.bx.psu.edu/repos/devteam/ncbi_blast_plus/ncbi_blastp_wrapper/0.3.1 not found error. Which is strange as we have installed this tool, maybe its just my bad internet connection.

pravs3683 commented 5 years ago

Thanks Bjorn, I will check with the developer and re-submit the workflow for the metabolomics part. Meanwhile, can we please have Metaproteomics and Proteogenomics workflows submitted?

Thanks, Praveen

On Sat, Dec 15, 2018 at 3:29 AM Björn Grüning notifications@github.com wrote:

@bgruening commented on this pull request.

In training/metabolomics/F1000_Metabolomics_Query_Tabular/F1000_Metabolomics_Query_Tabular_Mass_Adjustment.ga https://github.com/usegalaxy-eu/workflow-testing/pull/35#discussion_r241943835 :

  • "tool_id": null,
  • "tool_state": "{}",
  • "tool_version": null,
  • "type": "data_input",
  • "uuid": "1178cd10-d91a-4382-8006-6d95ad4ac366",
  • "workflow_outputs": [
  • {
  • "label": null,
  • "output_name": "output",
  • "uuid": "aa65b6dc-87e5-44ce-80a0-a47be5078baa"
  • }
  • ]
  • },
  • "3": {
  • "annotation": "",
  • "content_id": "testtoolshed.g2.bx.psu.edu/repos/eslerm/vkmz_qt/vkmz_qt/1.3.1",

@pravs3683 https://github.com/pravs3683 we do not have this tool installed .... its coming from the test toolshed which we would like to avoid.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/usegalaxy-eu/workflow-testing/pull/35#pullrequestreview-185348772, or mute the thread https://github.com/notifications/unsubscribe-auth/AFqnBUmwGljrfN-5KEb5KYD_Vx2zQ048ks5u5MD7gaJpZM4ZUOo_ .

bgruening commented 5 years ago

Ok, do you want to remove the non-functional workflows from this PR. Next time just create separate PRs, the first one was perfect and I was ready to merge it :)

Thanks again!

pravs3683 commented 5 years ago

Sure. I will do that. I will do a separate PR for each one. Thanks Bjorn