search

uselagoon / build-deploy-tool

Tool to generate build resources
2 stars 5 forks source link

Backup schedules define common bucket names #186

Open smlx opened 3 years ago

smlx commented 3 years ago

Describe the bug Schedules with the same project name on different clusters will create buckets with the same name. This is a problem, one of the baas operators will succeed in claiming the bucket name and the other will return errors like:

Last reported error: Connection to S3 endpoint not possible: 400 Bad Request

To Reproduce Steps to reproduce the behavior:

  1. Define a schedule object with the same bucket name on clusters in different regions.
  2. See errors in the backup logs of one of them.

Expected behavior Bucket names should be globally unique. Maybe a random suffix?

Screenshots n/a

Additional context n/a

smlx commented 3 years ago

Just noting that adding a random suffix to the bucket name in the schedule object does indeed fix this issue.

tobybellwood commented 3 years ago

(as long as we don't add the same random suffix to the same project name in two clusters :scream:)

Once we get better project naming (to include full cluster details) all projects will be truly unique.