uselagoon / build-deploy-tool

Tool to generate build resources
2 stars 5 forks source link

Support specifying multiple ports for basic services using labels #268

Open sjerdo opened 7 months ago

sjerdo commented 7 months ago

Hi!

This is a feature request. We'd like to set multiple ports for a basic container. Currently only one port can be set using label lagoon.service.port in docker-compose.yml

We'd like to set an additional port to gain access to the administration interface of one of the images we're running.

Would it be possible to add support for specifying at least one additional port to a service?

shreddedbacon commented 7 months ago

Hi @sjerdo we've discussed this before, and we do have a solution that is currently in a proof of concept phase that allows for consuming the ports that are defined in the docker-compose service.

Once we get further along in the development of that, we'll let you know

fruitl00p commented 4 weeks ago

Any updates on this? We've encountering another situation where having two ports defined would be helpful. (one internally between nodes, one to the outside)

shreddedbacon commented 4 weeks ago

Any updates on this? We've encountering another situation where having two ports defined would be helpful. (one internally between nodes, one to the outside)

Yep, this will come as part of #289

That pullrequest has been flagged for inclusion in the next release, so hopefully it will make it in, but there is always a chance it will be pushed out as it is quite a large pullrequest.