search

uselagoon / lagoon-charts

A collection of Helm charts for Lagoon and associated services.
Apache License 2.0
11 stars 9 forks source link

introduce tests to ensure chart image repository/tags exist #187

Open tobybellwood opened 3 years ago

tobybellwood commented 3 years ago

Given the complex inter-relations between the chart versions and lagoon versions, we should introduce a test that ensures that all images referenced in the charts are actually pullable. Currently, there is no output to GitHub Actions if the rollout of a chart fails because of a missing image.

Sun, 20 Dec 2020 23:36:26 GMT
Creating namespace 'lagoon-core-kirjn6x79v'...
Sun, 20 Dec 2020 23:36:26 GMT
namespace/lagoon-core-kirjn6x79v created
Sun, 20 Dec 2020 23:51:33 GMT
Error: timed out waiting for the condition

There's a pretty neat solution at https://github.com/helm-lab/helm-images/blob/master/images.sh using a dry-run to extract the image refs.

smlx commented 3 years ago

Hey @tobybellwood could you provide a link to an example test run with this issue?

tobybellwood commented 3 years ago

ha! Most of mine from last week until I figured it out! Here's one from today - https://github.com/uselagoon/lagoon-charts/runs/1586136229?check_suite_focus=true

The issue is at https://github.com/uselagoon/lagoon-charts/runs/1586136229?check_suite_focus=true#step:8:3505

smlx commented 3 years ago

I'm confused, isn't that error what you want to see?

tobybellwood commented 3 years ago

yeah - sorry - it took a lot of hunting to work out what it was - the initial error was that it "timed out".

This isn't a must-have, just a nice to have -I'll think about it a bit!

smlx commented 3 years ago

I hunted around in the github action s documentation, couldn't find anything about highlighting logs based on regex.

smlx commented 3 years ago

Hey I'm just grooming issues - is this still a problem?