search

uselagoon / lagoon-charts

A collection of Helm charts for Lagoon and associated services.
Apache License 2.0
11 stars 10 forks source link

Upgrade nats subchart to v1.0 #602

Open smlx opened 1 year ago

smlx commented 1 year ago

This PR upgrades the NATS subchart dependency to 1.0.

This is a breaking change. The NATS chart has completely restructured its configuration between v0.x and v1.x. So by necessity the NATS subchart configuration of lagoon-core and lagoon-remote also had to be restructured. In general, the major upstream change affecting the Lagoon charts is that nats.* values have mostly been moved to nats.config.*.

In particular, the following values required by the Lagoon charts have changed:

Lagoon Core:

Old path New path
nats.cluster.name nats.config.cluster.name
natsConfig.tls.secretData."server.crt" natsConfig.tls.secretData."tls.crt"
natsConfig.tls.secretData."server.key" natsConfig.tls.secretData."tls.key"

Lagoon Remote:

Old path New path
nats.cluster.name nats.config.cluster.name
natsConfig.tls.secretData."client.crt" natsConfig.tls.secretData."tls.crt"
natsConfig.tls.secretData."client.key" natsConfig.tls.secretData."tls.key"

In addition, any other NATS subchart configuration options that may have been added (anything under nats.* in the values.yaml of lagoon-core and lagoon-remote) will most likely require updating.

There are upstream notes on the changes in the NATS chart here.

The other change in this PR is that the client certificates presented by Lagoon Remote are now validated by NATS in Lagoon Core (they were not previously validated correctly). This should not be a breaking change if the previous instructions for generating certificates were followed correctly.

Also note that due to the breaking change this is a major version bump for lagoon-core from v1.x to v2.x. This is not a major version bump for lagoon-remote because that is still at v0.x.