search

uselagoon / lagoon-charts

A collection of Helm charts for Lagoon and associated services.
Apache License 2.0
11 stars 10 forks source link

fix: avoid installing the registry multiple times #638

Closed smlx closed 4 months ago

smlx commented 6 months ago

While the fill-test-ci-values target's dependency on install-registry was correctly manipulated by the SKIP_INSTALL_REGISTRY variable, the install-lagoon-build-deploy target had a hard-coded dependency on install-registry. The result was that the registry would get installed multiple times anyway via the fill-test-ci-values target via an indirect dependency.

Fix that by removing the dependency that install-lagoon-build-deploy has on install-registry when SKIP_INSTALL_REGISTRY=true.

shreddedbacon commented 6 months ago

running make TESTS=[nginx] k3d/test in uselagoon/lagoon. Not hugely noticeable difference. I think it is probably worth merging though

before: 

real    21m31.993s
user    0m46.142s
sys 0m8.614s

with this branch:

real    20m11.619s
user    0m44.983s
sys 0m8.093s

Only shaved off a small amount of time