search

uselagoon / lagoon-charts

A collection of Helm charts for Lagoon and associated services.
Apache License 2.0
11 stars 9 forks source link

CDN service annotation support #642

Closed smlx closed 9 months ago

smlx commented 9 months ago

Newer versions of the AWS load balancer controller change the default behaviour of LoadBalancer objects to be internal (private IP address) rather than internet-facing. The interface for making a LoadBalancer internet-facing is now an annotation on the k8s service object.

So this PR adds support for annotations on the CDN service, which is the only one intended to be used as a LoadBalancer.

tobybellwood commented 9 months ago

I stumbled into issues testing locally, as the kubectl container couldn't build (the alpine pkgs wouldn't install kubectl and jq) - but I replaced it with uselagoon/tests:latest - which has them preinstalled, and it worked fine.

------------------------------------------------------------------------------------------------------------------------
==> Logs of container lagoon-logging-7l8a9hjbxf-logs-dispatcher-test-cdn-service-annotations
------------------------------------------------------------------------------------------------------------------------
fetch https://dl-cdn.alpinelinux.org/alpine/v3.19/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.19/community/x86_64/APKINDEX.tar.gz
WARNING: fetching https://dl-cdn.alpinelinux.org/alpine/v3.19/main: could not connect to server (check repositories file)
WARNING: fetching https://dl-cdn.alpinelinux.org/alpine/v3.19/community: could not connect to server (check repositories file)
ERROR: unable to select packages:
  jq (no such package):
    required by: world[jq]
  kubectl (no such package):
    required by: world[kubectl]