search

uselagoon / lagoon-images

This repository builds the images used in Lagoon and local development environments
Apache License 2.0
26 stars 31 forks source link

Revisit php performance configuration #990

Open dasrecht opened 1 month ago

dasrecht commented 1 month ago

During some performance related work for a client, i realized that our images set pcre.jit to 0 https://github.com/uselagoon/lagoon-images/blame/main/images/php-fpm/00-lagoon-php.ini.tpl#L23-L23C9

This seems to only affect the 00-lagoon-php config, but I think we should revisit this for the default configuration because pcre.jit might be disabled on the default configuration.

Based on the php.net configuration this should be set to 1 per default which also has a performance gain on regex heavy php code https://www.php.net/manual/en/pcre.configuration.php

dasrecht commented 1 month ago

There seems to be some discussion about enabling or disabling JIT by default https://github.com/oerdnj/deb.sury.org/issues/1924