search

uselagoon / lagoon-ui

Apache License 2.0
6 stars 2 forks source link

Recommended fixes/changes to organizations #189

Closed DaveDarsa closed 7 months ago

DaveDarsa commented 8 months ago
  1. changes organization header gradient
  2. changes various button tooltips
  3. changes "view in dashboard" link
  4. changes some of the placeholders
  5. removes border highlight on non clickable table rows
shreddedbacon commented 8 months ago

The header gradient to me seems a bit off, I was initially thrown off by it when I had a quick look because I thought maybe something with the page rendered incorrectly

If the idea of the gradient is to distinguish you're in a different part of the UI for organizations, it doesn't really make it obvious

shreddedbacon commented 7 months ago

Some small issues/wording changes

On the manage page of the organzations UI when removing a user that has some manager level, the tooltip on the button should change from Delete user to Remove user as you aren't deleting the user from lagoon, you're removing their access to manage the organization. image Suggested wording:

This action will remove user default-user@ben-testing from management of the organization ben-test-org.

On the projects page of the organizations UI, when deleting a project, the message says it will delete it from the organization. This isn't entirely accurate, as it is a destructive action. The project is completely deleted from Lagoon, not just deleted from the organization. image Suggested wording?:

This action will delete project ben-testing from Lagoon and the organization.
DaveDarsa commented 7 months ago

@shreddedbacon @tobybellwood @CGoodwin90 I've tried numerous ways to include the <ErrorAlert /> component we use for cancelling deployment/task and in new environments.

The problem lies with either the <Mutation /> component from apollo, or react-modal that we use - multiple instances of errors get rendered; even if we limit the alert component to just one, the old instance gets destroyed and replaced with a new one, which ruins the UX.

Aside from that, I think this pr is good to go.