Closed mattswann closed 7 months ago
When linking a group or notification IF there is no existing group or notification add a selection to create one. This would trigger the same modal that exists to create only there is an option to 'Add to current project' before confirming the create action.
I wouldn't do this, I would direct the user to the notifications
page in the UI. Having it create the notification in the projects scope could give a false impression that this notification is only for this project, when currently, notifications are not scoped like this.
Notifications are scoped in a one to many relationship, where one notification can be assigned to many projects.
This also means that the Edit (pencil)
button of a notification in the project page should either be removed, or link to the organizations notification management page. As again, it could give a false impression it is being edited for that project only
When linking a group or notification IF there is no existing group or notification add a selection to create one. This would trigger the same modal that exists to create only there is an option to 'Add to current project' before confirming the create action.
I wouldn't do this, I would direct the user to the
notifications
page in the UI. Having it create the notification in the projects scope could give a false impression that this notification is only for this project, when currently, notifications are not scoped like this.Notifications are scoped in a one to many relationship, where one notification can be assigned to many projects.
This also means that the
Edit (pencil)
button of a notification in the project page should either be removed, or link to the organizations notification management page. As again, it could give a false impression it is being edited for that project only
@DaveDarsa got an existing PR for this, the edit button links to the notifications
page. Can build on this if required.
When linking a group or notification IF there is no existing group or notification add a selection to create one. This would trigger the same modal that exists to create only there is an option to 'Add to current project' before confirming the create action.
I wouldn't do this, I would direct the user to the
notifications
page in the UI. Having it create the notification in the projects scope could give a false impression that this notification is only for this project, when currently, notifications are not scoped like this. Notifications are scoped in a one to many relationship, where one notification can be assigned to many projects. This also means that theEdit (pencil)
button of a notification in the project page should either be removed, or link to the organizations notification management page. As again, it could give a false impression it is being edited for that project only@DaveDarsa got an existing PR for this, the edit button links to the
notifications
page. Can build on this if required.
awesome @CGoodwin90 - could you merge it into #189 as all the changes mentioned in this issue are there
All of the mentioned issues fixed in #189
ORGANIZATIONS Overview
Table rows
Action Buttons
Buttons
Input fields
[x] Anytime data validation is used for an input field, please describe the required validation. For example, adding a new group only accepts lowercase, number and '-'![Data validation](https://github.com/uselagoon/lagoon/assets/8729943/fc27723a-b6f5-4ad8-b0ba-67ea86459424)
[x] Adding a new email notification is bugged, there appears to be no validation![Email notification](https://github.com/uselagoon/lagoon/assets/8729943/1c3599b6-a4df-4e74-b260-4896bd863d29)
[x] If there is pre-existing information available please add it to the field. For example, when changing a users role allow the existing role to appear as selected.
Placeholder Text
[x] Change placeholder when adding a new notification to 'Make a selection'![Xnip2023-11-08_09-17-40](https://github.com/uselagoon/lagoon/assets/8729943/48b3b48c-5c5f-4d56-a153-09baa5f32cd5)
[x] Change placeholder when adding a project branch to 'Enter branch name'
[x] Add info icon and hover-over with the following copy 'When using an SSH git URL make sure that you copy the full path and have permission to add a deploy key and webhook. Public repositories can also be used.'![New project modal](https://github.com/uselagoon/lagoon/assets/8729943/3bb3c727-427a-4991-881d-9e3f27917884)
Linking in a Project
LAGOON DASHBOARD
Supporting Files Figma Link --> https://www.figma.com/file/XLrZn1fEfEeEkDICLH9QbX/Lagoon---Orgs-UI-updates?type=design&node-id=0%3A1&mode=design&t=xYWfNBU2ChRmeyZt-1
Reference Images
![groups](https://github.com/uselagoon/lagoon/assets/8729943/6f2b5206-e503-4a46-831a-8619a412bf97)