uselagoon / lagoon-ui

Apache License 2.0
6 stars 2 forks source link

Organizations - UI enhancements #190

Closed mattswann closed 7 months ago

mattswann commented 8 months ago

ORGANIZATIONS Overview

Table rows

Action Buttons

Buttons

Input fields

Placeholder Text

Linking in a Project

LAGOON DASHBOARD

Supporting Files Figma Link --> https://www.figma.com/file/XLrZn1fEfEeEkDICLH9QbX/Lagoon---Orgs-UI-updates?type=design&node-id=0%3A1&mode=design&t=xYWfNBU2ChRmeyZt-1

Reference Images Projects projects _ project groups

shreddedbacon commented 8 months ago

When linking a group or notification IF there is no existing group or notification add a selection to create one. This would trigger the same modal that exists to create only there is an option to 'Add to current project' before confirming the create action.

I wouldn't do this, I would direct the user to the notifications page in the UI. Having it create the notification in the projects scope could give a false impression that this notification is only for this project, when currently, notifications are not scoped like this.

Notifications are scoped in a one to many relationship, where one notification can be assigned to many projects.

This also means that the Edit (pencil) button of a notification in the project page should either be removed, or link to the organizations notification management page. As again, it could give a false impression it is being edited for that project only image

CGoodwin90 commented 8 months ago

When linking a group or notification IF there is no existing group or notification add a selection to create one. This would trigger the same modal that exists to create only there is an option to 'Add to current project' before confirming the create action.

I wouldn't do this, I would direct the user to the notifications page in the UI. Having it create the notification in the projects scope could give a false impression that this notification is only for this project, when currently, notifications are not scoped like this.

Notifications are scoped in a one to many relationship, where one notification can be assigned to many projects.

This also means that the Edit (pencil) button of a notification in the project page should either be removed, or link to the organizations notification management page. As again, it could give a false impression it is being edited for that project only image

@DaveDarsa got an existing PR for this, the edit button links to the notifications page. Can build on this if required.

DaveDarsa commented 8 months ago

When linking a group or notification IF there is no existing group or notification add a selection to create one. This would trigger the same modal that exists to create only there is an option to 'Add to current project' before confirming the create action.

I wouldn't do this, I would direct the user to the notifications page in the UI. Having it create the notification in the projects scope could give a false impression that this notification is only for this project, when currently, notifications are not scoped like this. Notifications are scoped in a one to many relationship, where one notification can be assigned to many projects. This also means that the Edit (pencil) button of a notification in the project page should either be removed, or link to the organizations notification management page. As again, it could give a false impression it is being edited for that project only image

@DaveDarsa got an existing PR for this, the edit button links to the notifications page. Can build on this if required.

awesome @CGoodwin90 - could you merge it into #189 as all the changes mentioned in this issue are there

DaveDarsa commented 8 months ago

All of the mentioned issues fixed in #189