search

uselagoon / lagoon-ui

Apache License 2.0
6 stars 2 forks source link

Regression: Project search blocks user input #241

Closed rocketeerbkw closed 1 month ago

rocketeerbkw commented 2 months ago

When there are a lot of projects listed on the projects page, and I attempt to search for a project, the input box will block on the first character until the search completes and it ignores all other keys. So typing "example" will put "e" in the input box and then ignore "xample."

The better UX pattern is to be smarter about when to initiate the search, like waiting until typing stops or until after a few keys. The experience is worsened because doing a search based on a single key like "e" will likely not reduce the list in a meaningful way, so it's a wasted time.

I think this was a regression caused by the onChange added in https://github.com/uselagoon/lagoon-ui/pull/204.

DaveDarsa commented 2 months ago

The mentioned PR didn't actually change the filtering logic nor timing; it only allowed setting the initial search string as projects were loading, so I don't believe this was a regression.

The issue itself is fixed in #243 and can handle up to a couple thousand of entries. ( we might need to change how we display the project rows as rendering thousands of them is very expensive )