uselagoon / lagoon-ui

Apache License 2.0
6 stars 2 forks source link

Update notification in organizations broken #268

Open shreddedbacon opened 1 week ago

shreddedbacon commented 1 week ago

Given 2x slack notifications in an organization, if I edit the second one in the list, it works correctly.

If I edit the first one in the list though, it fails because it tries to update the second one in the list.

I think there is a bug in the way the modal loads for the first item that makes it consume the name of the second (or last) item of a specific type

CGoodwin90 commented 1 week ago

Hmm yeah in the update mutation it looks like all notifications are being called for the variable name, with the final one in the array always being what's updated. A super simple fix would be to add a new state variable to set the relevant notification name onClick of the edit btn, then pass that to the update mutation. But I'm sure there's a nicer way