uselagoon / lagoon

Lagoon, the developer-focused application delivery platform
https://docs.lagoon.sh/
Apache License 2.0
567 stars 149 forks source link

do not set certificate for `tls-acme: false` Ingress unless there is one #2795

Open Schnitzel opened 3 years ago

smlx commented 3 years ago

The reason for this is that it causes extra work for the ingress controller since it has to check for the secret, realise it is missing, log an error message, and then use the default certificate.

We need to only reference the TLS secret in the ingress if it already exists or will be created by cert-manager. So only if:

Maybe we should also consider removing an existing secret if tls-acme: false, and the secret is an ACME cert?