uselagoon / lagoon

Lagoon, the developer-focused application delivery platform
https://docs.lagoon.sh/
Apache License 2.0
552 stars 149 forks source link

Adds service to deleteFactsFromSource #3627

Closed bomoko closed 5 months ago

bomoko commented 7 months ago

This PR introduces the same functionality as an earlier PR https://github.com/uselagoon/lagoon/pull/2611

The rationale for its existence mirrors that of the earlier PR, but mutatis mutandis wrt facts.

Essentially, it allows us to better target facts for clearing, since multiple facts could potentially exist with the same name, same source, but on different services.

Think, for instance, a php-version collected by some process that runs on both the php-nginx service and a cli service, we want to be able to clear the facts from one of the services, without having it be cleared from both.

General Checklist

shreddedbacon commented 6 months ago

Good to merge from my perspective, this just extends an existing mutations input without any breaking changes, and the logic contained within appears sound for the description provided.