uselagoon / lagoon

Lagoon, the developer-focused application delivery platform
https://docs.lagoon.sh/
Apache License 2.0
552 stars 149 forks source link

Changing email address has unintended side effects #3656

Closed shreddedbacon closed 4 months ago

shreddedbacon commented 5 months ago

If I log in to the Lagoon UI then go to Your account which takes me to the keycloak account settings page and change my email address, my account name in Lagoon UI remains the same as my old email address, and I am unable to change my username to match my email address.

This has another issue in that most user interactions require the email address. Unfortunately, Lagoon seems to pass the email address in to a username look up when interacting with Keycloak, so while I can change my email address, I still need to do any interactions using my old email address because that is what my username is.

For example, if I change the maintainer@example.com email address to not-maintainer@example.com, I still need to use maintainer@example.com to add the user to a group or remove this user from a group.

shreddedbacon commented 5 months ago

The Lagoon UI also displays the username, not the email address, after changing it. And by default, Keycloak/Lagoon does not allow users to change their username, so while the email address is changed, the username and what is displayed to the user remains their old email address. image

EDIT: With the #3657 and https://github.com/uselagoon/lagoon-ui/pull/218 we could allow users to change their usernames within the Keycloak UI perhaps to correct possible issues of people wondering why their username is their old email address. It shouldn't really make much of a difference to Lagoon at that point, as everything Lagoon facing would be the email address