uselagoon / lagoon

Lagoon, the developer-focused application delivery platform
https://docs.lagoon.sh/
Apache License 2.0
552 stars 149 forks source link

chore: remove unneeded reference to legacy registry setting #3659

Closed shreddedbacon closed 4 months ago

shreddedbacon commented 5 months ago

General Checklist

Database Migrations

Just removes an unneeded reference to a registry. This variable is not consumed by anything in core beyond passing it through to the remote. The usage of this is from a historical perspective, it was used when Lagoon didn't have support for harbor in core, or harbor in remote.

It isn't related to the legacy harbor implementation in core either as these provide variables to the project in the form of INTERNAL_REGISTRY_X which get added to the build payload when it sent to a remote. The legacy harbor implementation in core is planning to be removed (#2907 , #3259, and others) and was announced as deprecated in v2.17.0

Closing issues

closes #2238