search

uselagoon / lagoon

Lagoon, the developer-focused application delivery platform
https://docs.lagoon.sh/
Apache License 2.0
548 stars 148 forks source link

Feature: Implements `getNotificationByNameAndType` #3669

Closed CGoodwin90 closed 3 weeks ago

CGoodwin90 commented 4 months ago

Implements getNotificationByNameAndType allowing for a notification to be retreived by its name and type. Retreives both unassigned & assigned notifications.

shreddedbacon commented 3 weeks ago

I'm wondering if this is required or not now. Was there a reason for its need?

I'm wondering if allNotifications in #3671 could be extended to have an optional name input and omit the type input entirely? (or leave type too, and handle the permissions the same way this does)

CGoodwin90 commented 3 weeks ago

I'm wondering if this is required or not now. Was there a reason for its need?

I'm wondering if allNotifications in #3671 could be extended to have an optional name input and omit the type input entirely? (or leave type too, and handle the permissions the same way this does)

No specific usecase, it was purely so we had some way to get the unassigned notifcations lost to the void. I like the idea of extending allNotifications to support the optional name, I can pull something together.

CGoodwin90 commented 3 weeks ago

Closing, replaced by https://github.com/uselagoon/lagoon/pull/3740