uselagoon / lagoon

Lagoon, the developer-focused application delivery platform
https://docs.lagoon.sh/
Apache License 2.0
560 stars 149 forks source link

Improvement: validate migrating labels for active standby ingress migrations #3682

Closed shreddedbacon closed 6 months ago

shreddedbacon commented 6 months ago

General Checklist

Database Migrations

This refactors the activestandby task to perform validations of the migrating status label before migrations take place. It ensures that the label exists on the resources before they are migrated, and then post migration ensures that the label is reset.

This is done to help prevent the potential for race condition between the label being added to the ingress right before the migration of that ingress takes place.

shreddedbacon commented 6 months ago

Just to clarify, it doesn't eliminate the potential for a race