search

uselagoon / remote-controller

A group of controllers for handling Lagoon builds and tasks in Kubernetes or Openshift
5 stars 1 forks source link

Define build image in the controller #12

Closed shreddedbacon closed 3 years ago

shreddedbacon commented 4 years ago

It should be possible to override the build image used at the controller level. This PR adds this functionality by allowing 2 ways to do it

First is with a flag when starting the manager

--override-builddeploy-image=uselagoon/kubectl-build-deploy-dind:latest

The second is via an Environment variable OVERRIDE_BUILD_DEPLOY_DIND_IMAGE

This PR also removes support for LagoonBuild.Spec.Openshift in favour of the controller being told it is running in an Openshift by using the flag

--is-openshift=true

The reason for this is to allow Lagoon itself to be able to use the same ActiveSystemsX of lagoon_controllerX type between Openshift and Kubernetes and let the controller handle deciding what it needs to itself.

closes #11