search

uselagoon / remote-controller

A group of controllers for handling Lagoon builds and tasks in Kubernetes or Openshift
5 stars 1 forks source link

Support custom backup/restore locations #147

Closed cdchris12 closed 2 years ago

cdchris12 commented 2 years ago

With https://github.com/uselagoon/lagoon/pull/2820 now merged in, Lagoon now supports custom backup and restore locations natively. Once the remote-controller has support for accepting and passing these variables, we'll have the ability to setup custom backup/restore locations on a per-cluster basis.

shreddedbacon commented 2 years ago

If these values only get passed in via build pods, remote-controller can support passing in any LAGOON_FEATURE_FLAG_DEFAULT|FORCE prefixed variables directly into build pods. The logic of remote-controller has no need to understand what these variables are or what they do, only that they exist.

We should update the build script to leverage these instead, this makes it obvious when the controller is providing a value then.

EDIT: The reason we should do this is because then we aren't reliant on a release of remote-controller just to support some arbitrary feature or flag that can just be added to the remote-controller and passed directly into build pods. Only Lagoon build script needs to be changed to support things like this going forward.

shreddedbacon commented 2 years ago

Closing in favor of https://github.com/uselagoon/build-deploy-tool/issues/55 (and there may be one that makes it into uselagoon/lagoon if needed)