search

uselagoon / remote-controller

A group of controllers for handling Lagoon builds and tasks in Kubernetes or Openshift
5 stars 1 forks source link

errors should fail builds #149

Closed shreddedbacon closed 2 years ago

shreddedbacon commented 2 years ago

In most cases of the controller handling a build, any error encountered after the build has been accepted should result in the build failing.

Currently the behaviour of the controller is to try and reconcile again which results in the error. Failing builds would be more appropriate, and sending a build log message with a brief description of what went wrong to aid in support troubleshooting.

shreddedbacon commented 2 years ago

closing as duplicate of #52