uselagoon / remote-controller

A group of controllers for handling Lagoon builds and tasks in Kubernetes or Openshift
5 stars 1 forks source link

fix: harbor robot account name generation for environments with double dash #216

Closed shreddedbacon closed 1 year ago

shreddedbacon commented 1 year ago

Checklist

Some environments in Lagoon can be deployed with double dashes in their name. While this is supported (but not something encouraged), Harbor 2.2.0+ has enforcement on robot account names, which makes environments with double dashes invalid. Previous versions of Harbor allowed this so it went unknown until recently.

Now the process will validate the robot account name, and change it to use hashed environment name if the supplied name is invalid.

Closing issues

closes #215